[PATCH] D144250: [AMDGPU] Simplify widenScalar condition for BigTy for G_(UN)MERGE_VALUES

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 02:22:07 PST 2023


foad added a comment.

This is NFC. The condition was "not a power of two and not a multiple of 16". But this was already clamped to at least S32 on line 1616, so the condition simplifies to "not a multiple of 16".

However, I am sceptical that this condition is what was intended, since it doesn't seem to match the widening rule of "Pick the next power of 2, or a multiple of 64 over 128".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144250/new/

https://reviews.llvm.org/D144250



More information about the llvm-commits mailing list