[PATCH] D144108: [mlir][LinAlg][Transform] Add a transform op for conv2d to im2col

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/ConvertConv2DToImg2Col.cpp:48
+//
+// A convolution operaton can be written as a matrix-matrix multiplication by
+// unfolding the cross corrolation between input and filter and explicitly copy
----------------
nit: operation


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/ConvertConv2DToImg2Col.cpp:49
+// A convolution operaton can be written as a matrix-matrix multiplication by
+// unfolding the cross corrolation between input and filter and explicitly copy
+// overlapped sliding window inputs.
----------------
nit: cross-correlation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144108/new/

https://reviews.llvm.org/D144108