[PATCH] D144244: [X86]rearange X86InstrInfo.td

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrAsmAlias.td:571
+def : InstAlias<"add{q}\t{$imm, %rax|rax, $imm}", (ADD64ri8 RAX, i64i8imm:$imm), 0>;
+def : InstAlias<"and{q}\t{$imm, %rax|rax, $imm}", (AND64ri8 RAX, i64i8imm:$imm), 0>;
+def : InstAlias<"cmp{q}\t{$imm, %rax|rax, $imm}", (CMP64ri8 RAX, i64i8imm:$imm), 0>;
----------------
We can move the alias of conditional instructions to here too. Try grep "InstAlias" in X86 td files


================
Comment at: llvm/lib/Target/X86/X86InstrBasic.td:1
+//===-- X86InstrBasic.td - Main X86 Instruction Definition -*- tablegen -*-===//
+//
----------------
Actually, the instructions here are not basic. I think "Misc" is more situatable


================
Comment at: llvm/lib/Target/X86/X86InstrBasic.td:9
+//
+// This file describes the X86 instruction set, defining the instructions which 
+// are needed for code generation, machine code emission, and analysis.
----------------
Update the comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144244/new/

https://reviews.llvm.org/D144244