[PATCH] D144154: [X86]Use Class to refactor ArithMetic td file in X86

[Wang, Xin via Phabricator via llvm-commits]

XinWang10 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:582
+
+// BinOpRRxMI - Binary instructions with inputs "reg/[mem], imm".
+class BinOpRRxMI<bits<8> opcode, Format f, string mnemonic, X86TypeInfo info, 
----------------
skan wrote:
> This class is misleading. From the comment "BinOpRRxMI - Binary instructions with inputs "reg/[mem], imm". I would understand the input is reg, imm or  mem imm. In fact, all the thing it says is that "I have a output register and I have two input"
> 
> I suggest to remove this class and use ITy instead.
Agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144154/new/

https://reviews.llvm.org/D144154