[PATCH] D143880: [LoongArch] Emit bytepick for picking from concatenation of two values

[Lu Weining via Phabricator via llvm-commits]

SixWeining accepted this revision.
SixWeining added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!

Yes, I think the ISA's pseudo-code description is incorrect. Maybe it shoud be:

  bytepick.w:
  
    tmp = {GR[rk][31:0],  GR[rj][31:0]}
  
    GR[rd] = SignExtend(tmp[8×(8-sa2)-1:8×(4-sa2)], GRLEN)
  
    or
  
    GR[rd] = SignExtend(tmp[8×(4-sa2)+31:8×(4-sa2)], GRLEN)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143880/new/

https://reviews.llvm.org/D143880