[PATCH] D144154: [X86]Use Class to refactor ArithMetic td file in X86
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 16 22:29:34 PST 2023
skan added inline comments.
================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:158
-// BinOpRR - Instructions like "add reg, reg, reg".
+// BinOpRR - Binary instructions with two operands "reg, reg".
class BinOpRR<bits<8> opcode, string mnemonic, X86TypeInfo typeinfo,
----------------
Binary already indicates two. I would suggest "Binary instructions with inputs "reg, reg"
================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:281
// BinOpRI_RF - Instructions like "add reg, reg, imm".
class BinOpRI_RF<bits<8> opcode, string mnemonic, X86TypeInfo typeinfo,
----------------
Binary instructions with inputs "reg, imm", output "reg" and write EFLAGS
================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:287
(opnode typeinfo.RegClass:$src1, typeinfo.ImmOperator:$src2))]>;
// BinOpRI_RFF - Instructions like "adc reg, reg, imm".
class BinOpRI_RFF<bits<8> opcode, string mnemonic, X86TypeInfo typeinfo,
----------------
Binary instructions with inputs "reg, imm", output "reg" and read/write EFLAGS
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144154/new/
https://reviews.llvm.org/D144154
More information about the llvm-commits
mailing list