[llvm] 39811e2 - [llvm][test] enable/disable -verify-machineinstrs where possible for callbr

[Nick Desaulniers via llvm-commits]

Author: Nick Desaulniers
Date: 2023-02-16T20:28:18-08:00
New Revision: 39811e2e537de415b68d1ed9edee716dbc59a4ed

URL: https://github.com/llvm/llvm-project/commit/39811e2e537de415b68d1ed9edee716dbc59a4ed
DIFF: https://github.com/llvm/llvm-project/commit/39811e2e537de415b68d1ed9edee716dbc59a4ed.diff

LOG: [llvm][test] enable/disable -verify-machineinstrs where possible for callbr

I introduced new tests in
commit 5cc1016a57b3 ("[llvm][SelectionDAGBuilder] codegen callbr.landingpad intrinsic")
https://reviews.llvm.org/D140160
that fails expensive checks. Disable -verify-machineinstrs in those
tests for now. Enable it in other tests for now, since MachineVerifier
isn't on by default for assertion builds.

Link: https://github.com/llvm/llvm-project/issues/60827

Added: 
    

Modified: 
    llvm/test/CodeGen/AArch64/callbr-asm-outputs-indirect-isel.ll
    llvm/test/CodeGen/PowerPC/callbr-asm-outputs-indirect-isel.ll
    llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel-m32.ll
    llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/AArch64/callbr-asm-outputs-indirect-isel.ll b/llvm/test/CodeGen/AArch64/callbr-asm-outputs-indirect-isel.ll
index c04814b9e34f..cf22216daf51 100644
--- a/llvm/test/CodeGen/AArch64/callbr-asm-outputs-indirect-isel.ll
+++ b/llvm/test/CodeGen/AArch64/callbr-asm-outputs-indirect-isel.ll
@@ -1,6 +1,6 @@
 ; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 
-; RUN: llc -mtriple=aarch64-linux-gnu %s -o - \
+; RUN: llc -mtriple=aarch64-linux-gnu %s -o - -verify-machineinstrs \
 ; RUN:   -start-before=aarch64-isel -stop-after=finalize-isel \
 ; RUN:   -global-isel=0 -fast-isel=0 | FileCheck %s
 

diff  --git a/llvm/test/CodeGen/PowerPC/callbr-asm-outputs-indirect-isel.ll b/llvm/test/CodeGen/PowerPC/callbr-asm-outputs-indirect-isel.ll
index 2fe6c618da71..987b8da75ccf 100644
--- a/llvm/test/CodeGen/PowerPC/callbr-asm-outputs-indirect-isel.ll
+++ b/llvm/test/CodeGen/PowerPC/callbr-asm-outputs-indirect-isel.ll
@@ -1,5 +1,6 @@
 ; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
-; RUN: llc %s -o - -stop-after=finalize-isel -start-before=ppc-isel | FileCheck %s
+; RUN: llc %s -o - -verify-machineinstrs \
+; RUN:   -stop-after=finalize-isel -start-before=ppc-isel | FileCheck %s
 
 target datalayout = "e-m:e-i64:64-n32:64-S128-v256:256:256-v512:512:512"
 target triple = "powerpc64le-unknown-linux-gnu"

diff  --git a/llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel-m32.ll b/llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel-m32.ll
index 5fe6986f82f5..2086f13095de 100644
--- a/llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel-m32.ll
+++ b/llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel-m32.ll
@@ -1,6 +1,8 @@
 ; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+; FIXME(ndesaulniers): get this test to pass with -verify-machineinstrs
+; enabled. https://github.com/llvm/llvm-project/issues/60827
 ; RUN: llc -mtriple=i386-linux-gnu %s -o - -stop-after=finalize-isel \
-; RUN: -start-before=x86-isel | FileCheck %s
+; RUN:   -verify-machineinstrs=0 -start-before=x86-isel | FileCheck %s
 
 define i8 @emulator_cmpxchg_emulated() {
   ; CHECK-LABEL: name: emulator_cmpxchg_emulated

diff  --git a/llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel.ll b/llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel.ll
index c9e373bcfc21..ead0230a1c89 100644
--- a/llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel.ll
+++ b/llvm/test/CodeGen/X86/callbr-asm-outputs-indirect-isel.ll
@@ -1,6 +1,8 @@
 ; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+; FIXME(ndesaulniers): get this test to pass with -verify-machineinstrs
+; enabled. https://github.com/llvm/llvm-project/issues/60827
 ; RUN: llc -mtriple=x86_64-linux-gnu %s -o - -stop-after=finalize-isel \
-; RUN: -start-before=x86-isel | FileCheck %s
+; RUN:   -verify-machineinstrs=0 -start-before=x86-isel | FileCheck %s
 
 ; One virtual register, w/o phi
 define i32 @test0() {