[PATCH] D144154: [X86]Use Class to refactor ArithMetic td file in X86

[Wang, Xin via Phabricator via llvm-commits]

XinWang10 marked 13 inline comments as done and an inline comment as not done.
XinWang10 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrArithmetic.td:459
 
+//  UnaryOpM - Instructions like "inc [mem]"
+class UnaryOpM<bits<8> opcode, Format f, string mnemonic, X86TypeInfo info,
----------------
skan wrote:
> Could we change this comment? I never like this style of comment b/c it looks almost same as  "INCDECM - Instructions like "inc [mem]". which is confusing.
> 
> We may change the comment to “Unary instructions with a memory operand”
> 
> Similarly for other classes in this file like `BinOpMI8`, etc.
Yes, will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144154/new/

https://reviews.llvm.org/D144154