[PATCH] D144183: [X86][MC] Fix the bug of -output-asm-variant=1 for intel syntax

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 17:52:24 PST 2023


skan added a comment.

In D144183#4132541 <https://reviews.llvm.org/D144183#4132541>, @MaskRay wrote:

>> I believe the behavior is too weird to be called a feature.
>
> More importantly, the behavior does not match `llvm-mc -filetype=obj`. The new behavior matches `llvm-mc -filetype=obj` and `as -msyntax=intel -mnaked-reg`.

The encoding is right, w/o this patch, we can get still get a correct encoding for "lea     eax, [1*r15] " with llvm-mc. The issue here is that the output assembly is incorrect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144183/new/

https://reviews.llvm.org/D144183



More information about the llvm-commits mailing list