[PATCH] D143437: [llvm] Use pointer index type for more GEP offsets (pre-codegen)

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 15:27:20 PST 2023


jrtc27 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp:1066
+    // converted to integers) or those whose offset size is different from their
+    // pointer size (which means that doing integer arithmetic on them could
+    // affect that data) can't be lowered in this way.
----------------
As discussed on discourse, this isn't really what that means, at least not for CHERI, which was one of the influences for how the current pointer index type came to be (D42123)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143437/new/

https://reviews.llvm.org/D143437



More information about the llvm-commits mailing list