[PATCH] D143708: [RISCV] Add emulated TLS supported

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 13:45:23 PST 2023


MaskRay added a comment.

In D143708#4132222 <https://reviews.llvm.org/D143708#4132222>, @asb wrote:

> The consensus from the RISC-V LLVM sync-up call was that it makes sense to go ahead with this on the basis their are users, the infrastructure in LLVM already exists to use it etc, and it's a tiny patch to enable etc.
>
> In which case, assuming no-one who wasn't able to make it to the call wanted to raise strong objections, we can hopefully focus on code review of this patch and move it forwards.

I have a mild objection but I am fine if my opinion is overthrown. I think OpenBSD developers should take on the work to migrate to ELF TLS, not using this definitely.

`-femulated-tls` can be used for the current `*-linux-android*` and `*-openbsd*` target triples, and OpenBSD RISC-V, but not others. The test should be changed to use openbsd, not linux-gnu.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143708/new/

https://reviews.llvm.org/D143708



More information about the llvm-commits mailing list