[PATCH] D142375: [AMDGPU][CodeGen] Combine SDAG and global isel tests for intersect ray intrinsics.

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added a comment.

> No no, all the permutations should be tested. This is not a cosmetic choice, we should be testing these are handled correctly

That's what the comments say, yes. But then if vector versions have only been used to make sure the register operands are where the values actually land, maybe we can test that just by adding some extra arguments to flattened versions and thus make accidentally correct output sufficiently unlikely?

Tests like this don't feel to be the right place to test codegen'ing of moves implementing the `insertelement`s and cluttering tests checking them repeatedly for various kinds of calls probably doesn't make much sense as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142375/new/

https://reviews.llvm.org/D142375