[PATCH] D143760: [Codeview] Fix incorrect size determination for complex types.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a subscriber: hansw.
dblaikie added a comment.

+ at hansw for CV questions too.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1796-1797
   case dwarf::DW_ATE_complex_float:
+    // The CodeView size for a complex represents the size of
+    // an individual component.
     switch (ByteSize) {
----------------
When you say "The CodeView size" what do you mean? The size that some frontend is encoding in the size in the LLVM IR debug info metadata? Is it possible that the bug is in the frontend, rather than here?

(& looking at the boolean case above, I guess these `SimpleTypeKind::*N` are N in bits? Is that tru efor Boolean and Complex?)

I guess a broad question: Where's the data coming from that informs what's correct and motivates this patch/change?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143760/new/

https://reviews.llvm.org/D143760