[PATCH] D144128: [SLP] Check with target before vectorizing GEP Indices

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 09:30:00 PST 2023


jonpa marked an inline comment as done.
jonpa added a comment.

In D144128#4131910 <https://reviews.llvm.org/D144128#4131910>, @ABataev wrote:

> Could you check the throughput of (some of) the tests with and without your changes in godbolt?

Hmm, that sounds interesting, but I don't quite know how to go about that. Is godbolt supposed to show cycles somehow?

On SystemZ, this is a rather simple issue as extractions from vector registers into GPRs is considered expensive, so therefore it is basically always wrong to vectorize address computations. I was hoping that other targets could inspect their test changes and from that decide if it looks ok...?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144128/new/

https://reviews.llvm.org/D144128



More information about the llvm-commits mailing list