[PATCH] D144178: [CMake] Enforce LLVM_ENABLE_UNWIND_TABLES

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

We do have other examples of ternary state options., and making this ternary for the sake of compatibility is an intriguing idea.  However, I also ascribe to POLA/POLS.  Mapping `LLVM_ENABLE_UNWIND_TABLES` to `-funwind-tables` seems pretty reasonable to me.  The only time that you would want to disable these is if it is an embedded context where you do not care about debugging or crash analytics, where you should pretty quickly see the size impact.  If this plays out to be a problem to be enabled by default we can always revisit the ternary state.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144178/new/

https://reviews.llvm.org/D144178