[PATCH] D144166: [RISCV] For rv32, accept constants like 0xfffff800 as a valid simm12.
Luís Marques via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 16 06:33:11 PST 2023
luismarques added a comment.
The reasoning and approach makes sense to me. I haven't (yet) checked the implementation and test coverage in detail, so this is a weak approval only.
================
Comment at: llvm/test/MC/RISCV/rv32i-only-valid.s:9
+# CHECK-ASM: encoding: [0x13,0x85,0xf5,0xff]
+addi a0, a1, 4294967295
+# CHECK-ASM-AND-OBJ: ori a2, a3, -2048
----------------
Please add a comment with the hex representation. Personally, I can't eyeball these large ones and be sure it's exactly 0xFFFFFFFF.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144166/new/
https://reviews.llvm.org/D144166
More information about the llvm-commits
mailing list