[PATCH] D144128: [SLP] Check with target before vectorizing GEP Indices

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 05:41:51 PST 2023


jonpa updated this revision to Diff 497990.
jonpa added a comment.

> Can you try to move this check to buildTree_rec function, NotProfitableForVectorization lambda and make it return true if S.getOpcode() == Instruction::GetElementPtr && !TTI->prefersVectorizedAddressing()?

I added this, and it did seem to have some effect, although just two additional extractions less on SystemZ/SPEC.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144128/new/

https://reviews.llvm.org/D144128

Files:
  llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
  llvm/test/Transforms/SLPVectorizer/AArch64/ext-trunc.ll
  llvm/test/Transforms/SLPVectorizer/AArch64/gather-reduce.ll
  llvm/test/Transforms/SLPVectorizer/AArch64/getelementptr.ll
  llvm/test/Transforms/SLPVectorizer/SystemZ/gep-indices.ll
  llvm/test/Transforms/SLPVectorizer/X86/load-merge-inseltpoison.ll
  llvm/test/Transforms/SLPVectorizer/X86/load-merge.ll
  llvm/test/Transforms/SLPVectorizer/X86/minimum-sizes.ll
  llvm/test/Transforms/SLPVectorizer/X86/opaque-ptr.ll
  llvm/test/Transforms/SLPVectorizer/X86/partail.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144128.497990.patch
Type: text/x-patch
Size: 89676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230216/6cccb0d3/attachment.bin>


More information about the llvm-commits mailing list