[PATCH] D143277: [SME2][AArch64] Add multi-multi multiply-add long long intrinsics

Thu Feb 16 05:16:51 PST 2023

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM!

================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:2816

 multiclass sme2_mla_ll_array_vg2_multi<string mnemonic, bits<4> op,
                                        MatrixOperand matrix_ty,
----------------
kmclaughlin wrote:
> david-arm wrote:
> > Again, same suggestion as here https://reviews.llvm.org/D143276#inline-1386660, but feel free to ignore this if it doesn't make it any better!
> I think in this case it will not reduce much because the VG2 & VG4 instructions have to use separate classes (`sme2_mla_ll_array_vg2_multi` and `sme2_mla_ll_array_vg4_multi`)?
Fair point, silly me!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143277/new/

https://reviews.llvm.org/D143277