[PATCH] D144099: [WIP][AMDGPU] Fold more AGPR copies/PHIs in SIFoldOperands

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 04:55:25 PST 2023


Pierre-vh updated this revision to Diff 497965.
Pierre-vh marked 3 inline comments as done.
Pierre-vh added a comment.

The last big regression is now in test_mfma_loop_agpr_init on gfx908 where agpr-to-agpr copies are annoying.
I'm not sure yet how to fix that one, it seems to be because after PHIs are removed, we end up with copies like

  %83.sub1:areg_1024 = COPY %83.sub0:areg_1024

all over the place so after RA/removing RA pseudos, we get a lot of code to copy sub0 to sub1-31.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144099/new/

https://reviews.llvm.org/D144099

Files:
  llvm/lib/Target/AMDGPU/SIFoldOperands.cpp
  llvm/test/CodeGen/AMDGPU/acc-ldst.ll
  llvm/test/CodeGen/AMDGPU/mfma-loop.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144099.497965.patch
Type: text/x-patch
Size: 16743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230216/8795feba/attachment.bin>


More information about the llvm-commits mailing list