[PATCH] D144162: [AMDGPU] Replace LegacyDA with Uniformity Analysis in AnnotateUniformValues

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/divergent-branch-uniform-condition.ll:85
 ; UNIFORM-LABEL: Flow2:
-; UNIFORM-NEXT: br i1 %8, label %if1, label %endloop
-; UNIFORM-NOT: !amdgpu.uniform
+; UNIFORM-NEXT: br i1 %8, label %if1, label %endloop, !amdgpu.uniform
 ; UNIFORM: if1:
----------------
The comment at the start of this test says the following:

  11 ; This module creates a divergent branch in block Flow2. The branch is
  12 ; marked as divergent by the divergence analysis but the condition is
  13 ; not. This test ensures that the divergence of the branch is tested,
  14 ; not its condition, so that branch is correctly emitted as divergent.

It seems that the proposed change completely fails the intention of this test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144162/new/

https://reviews.llvm.org/D144162