[PATCH] D144172: [Support] [Windows] Don't check file access time in equivalent(file_status, file_status)

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

Interesting, that must have been a pain to track down.

Does the same issue also affect the LastWriteTime fields? I.e., if someone `touch`es a file between calls?

>From https://learn.microsoft.com/en-us/windows/win32/api/fileapi/ns-fileapi-by_handle_file_information it sounds like just comparing the LastWriteTime and VolumeSerialNumber should be enough to check file identities. Perhaps we should just do that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144172/new/

https://reviews.llvm.org/D144172