[PATCH] D144167: [UniformityAnalysis] Fix some file headers and pass names

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 03:11:44 PST 2023


foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/Analysis/UniformityAnalysis.cpp:128
 
 INITIALIZE_PASS_BEGIN(UniformityInfoWrapperPass, "uniforminfo",
+                      "Uniformity Analysis", true, true)
----------------
foad wrote:
> sameerds wrote:
> > Perhaps this should also be "uniformity"? For example, the loop info analysis and the cycle info analysis are simply called "loops" and "cycles" respectively. This might need changes in the lit tests that invoke this analysis by name.
> Yes, that seems consistent with other analyses.
This only changed the legacy pass name. The non-legacy pass name was already "uniformity" and that's what the tests use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144167/new/

https://reviews.llvm.org/D144167



More information about the llvm-commits mailing list