[PATCH] D143787: [X86] Add new pass `X86FixupISel` for fixing up machine-instruction selection.

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 02:47:00 PST 2023


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FixupISel.cpp:1
+//===-- X86FixupISels.cpp - use or replace ISel instructions -----------===//
+//
----------------
craig.topper wrote:
> Referring to ISel and running the pass so far from instruction selection is perhaps misleading.
I have the same concern, if it is required for `vpermli*`, maybe just name it `FixupVpermli`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143787/new/

https://reviews.llvm.org/D143787



More information about the llvm-commits mailing list