[PATCH] D144168: StackProtector: instrument noreturn paths before the call

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/stackprotect-noreturn.ll:1
+; RUN: llc -mtriple=riscv32-linux-gnu %s -o - | FileCheck %s
+
----------------
Please use update_llc_test_checks.py, at least for RISC-V, though I'd encourage its use for other architectures too. Also don't use a Linux triple unless it's strictly necessary, a plain riscv32 is normally sufficient, and be sure to test both 32-bit and 64-bit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144168/new/

https://reviews.llvm.org/D144168