[PATCH] D143883: [InstCombine] canonicalize urem as cmp+select

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 01:05:05 PST 2023


Allen marked an inline comment as done.
Allen added inline comments.


================
Comment at: llvm/include/llvm/Analysis/InstructionSimplify.h:244
+                        const SimplifyQuery &Q,
+                        const Instruction *CxtI = nullptr);
 
----------------
nikic wrote:
> Why the new parameter? You can use `SQ.withInstruction(I)` to change the context instruction.
Thanks your review, I update with SQ.getWithInstruction(&I).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143883/new/

https://reviews.llvm.org/D143883



More information about the llvm-commits mailing list