[PATCH] D137933: [llvm-debuginfo-analyzer] 08a - Memory Management

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

> Do you have any additional comments on the updated patch?

It looks like all the comments have been addressed or acknowledged, so LGTM.

I've put one question inline but I'm happy for you to address it (if it does need addressing) without another round of review.



================
Comment at: llvm/lib/DebugInfo/LogicalView/Core/LVType.cpp:261
+      else
+        TypesParam->push_back(Type);
+    }
----------------
Before your recent change this branch was taken if `options().getAttributeArgument()` is false, but now this branch is taken if `options().getAttributeArgument()` is true (and both `Type->getIsKindType()`  and `Type->getIsKindScope())` are false). Just checking - is the new behaviour correct?

And if so, what was the result of the previous incorrect behaviour? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137933/new/

https://reviews.llvm.org/D137933