[PATCH] D137933: [llvm-debuginfo-analyzer] 08a - Memory Management

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 00:21:08 PST 2023


CarlosAlbertoEnciso updated this revision to Diff 497907.
CarlosAlbertoEnciso added a comment.

Update the patch to reflect a change based on @dblaikie feedback.

Replaced the macro `LV_CREATE_OPERATION` with the explicit function:

  // Operations creation.
  LVOperation *createOperation(LVSmall OpCode, LVUnsigned Operand1,
                               LVUnsigned Operand2) {
    return new (AllocatedOperation.Allocate())
        LVOperation(OpCode, Operand1, Operand2);
  }


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137933/new/

https://reviews.llvm.org/D137933

Files:
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVLocation.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVObject.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVReader.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVScope.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVSupport.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVSymbol.h
  llvm/include/llvm/DebugInfo/LogicalView/LVReaderHandler.h
  llvm/include/llvm/DebugInfo/LogicalView/Readers/LVBinaryReader.h
  llvm/lib/DebugInfo/LogicalView/Core/LVLocation.cpp
  llvm/lib/DebugInfo/LogicalView/Core/LVScope.cpp
  llvm/lib/DebugInfo/LogicalView/Core/LVSymbol.cpp
  llvm/lib/DebugInfo/LogicalView/Core/LVType.cpp
  llvm/lib/DebugInfo/LogicalView/LVReaderHandler.cpp
  llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp
  llvm/lib/DebugInfo/LogicalView/Readers/LVELFReader.cpp
  llvm/unittests/DebugInfo/LogicalView/CompareElementsTest.cpp
  llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp
  llvm/unittests/DebugInfo/LogicalView/LocationRangesTest.cpp
  llvm/unittests/DebugInfo/LogicalView/LogicalElementsTest.cpp
  llvm/unittests/DebugInfo/LogicalView/SelectElementsTest.cpp
  llvm/unittests/DebugInfo/LogicalView/WarningInternalTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137933.497907.patch
Type: text/x-patch
Size: 69921 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230216/7647f47d/attachment-0001.bin>


More information about the llvm-commits mailing list