[PATCH] D144053: [LICM] Ensure LICM can hoist invariant.group

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 00:00:30 PST 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. Possibly there is some way to nicely integrate this directly into the MemorySSA clobber walker (which already has invariant.group support, but doesn't handle this case), but I think this is fine for now.



================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1180
 
+    auto MU = cast<MemoryUse>(MSSA->getMemoryAccess(LI));
+
----------------
Doesn't seem like the variable is needed anymore. If you want to keep it, use `auto *`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144053/new/

https://reviews.llvm.org/D144053



More information about the llvm-commits mailing list