[PATCH] D129735: [RISCV] Add new pass to transform undef to pseudo for vector values.

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 20:51:58 PST 2023


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVRVVInitUndef.cpp:175
+static bool isEarlyClobberMI(MachineInstr &MI) {
+  for (MachineOperand &MO : MI.operands()) {
+    if (!MO.isReg())
----------------
craig.topper wrote:
> Any idea why the llvm::any_of didn't work?
Because the thing that calls this is erasing from the MBB whilst it iterates over it... so this is the wrong fix and probably doesn't even work either


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129735/new/

https://reviews.llvm.org/D129735



More information about the llvm-commits mailing list