[PATCH] D144084: [LLD] [COFF] Don't try to detect MSVC installations in mingw mode

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 15:03:40 PST 2023


mstorsjo added inline comments.


================
Comment at: lld/COFF/Driver.cpp:1519
+      addLibSearchPaths();
+  } else {
+    if (args.hasArg(OPT_vctoolsdir, OPT_winsysroot))
----------------
Having a negated if condition, followed by an else (i.e. a double negation), is a bit non-ideal, but I feel the main codepath (first the main case is presented, followed by the exception to it) is easier to follow this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144084/new/

https://reviews.llvm.org/D144084



More information about the llvm-commits mailing list