[PATCH] D144084: [LLD] [COFF] Don't try to detect MSVC installations in mingw mode

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lld/COFF/Driver.cpp:1515
+    // installations when operating in mingw mode. (This also makes LLD ignore
+    // winsysroot and vctoolsdir arguments.)
+    detectWinSysRoot(args);
----------------
hans wrote:
> mstorsjo wrote:
> > hans wrote:
> > > i assume lld will warn about unused arguments if the user tries to use /winsysroot or /vctoolsdir in mingw mode?
> > No, lld doesn't warn about unclaimed arguments.
> Hmm, should we make it warn in this case? Just silently ignoring /winsysroot seems like a bad experience.
I guess it would be reasonable to print a warning here, if there are explicit command line arguments that we know we're not dealing with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144084/new/

https://reviews.llvm.org/D144084