[PATCH] D144066: [Pseudo probe] Duplicate probes in vectorized loop body.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 13:53:05 PST 2023


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/SampleProfile/pseudo-probe-loop-vectorize.ll:1
+; RUN: opt < %s -passes=loop-vectorize -force-vector-interleave=1 -force-vector-width=4 -S | FileCheck %s
+
----------------
 It looks like this should test LV behavior and only runs LV, so it should be moved to the LoopVectorize test directory?


================
Comment at: llvm/test/Transforms/SampleProfile/pseudo-probe-loop-vectorize.ll:48
+!0 = !{i64 3666282617048535130, i64 52824598631, !"test1"}
+!1 = !{!2, !2, i64 0}
+!2 = !{!"float", !3, i64 0}
----------------
This metadata should not be needed, can you remove it to make the test more compact?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144066/new/

https://reviews.llvm.org/D144066



More information about the llvm-commits mailing list