[PATCH] D142507: [AMDGPU] Split dot7 feature

Wed Feb 15 11:37:16 PST 2023

rampitec added a comment.

In D142507#4127505 <https://reviews.llvm.org/D142507#4127505>, @b-sumner wrote:

>> My current understanding is the c-p will go into already forked clang-16, but not to rocm 5.4. So rocm device-libs will be accompanied by the older clang-16 w/o this and stay compatible. Someone building from scratch will use latest clang-16 and staging device-libs with this change. Do you think this will work?
>
> I wouldn't recommend it.  I would patch whatever device libs are being built in association with clang-16, not staging.  Staging device libs is only appropriate for the staging compiler.  A hash of device libs from around the time that clang-16 stable released would probably be safe.

In general the idea is that compiler and device-libs should match. I guess the correct answer then users of clang-16 shall use rocm-5.4.x branch of the device libs?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142507/new/

https://reviews.llvm.org/D142507