[PATCH] D143925: [mlir] Make the vast majority of integration and runner tests work on Windows

Markus Böck via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 11:21:43 PST 2023


zero9178 added a comment.

In D143925#4129879 <https://reviews.llvm.org/D143925#4129879>, @aartbik wrote:

> The change now sticks on linux/cmake, but the bazel configuration I am monitoring is completely broken with this substitution mechanism.
> Do you have any pointers for me on where to start debugging this?
>
> I see a non-substituted command line
>
> 1. mlir-opt /usr/local/google/_blaze_ajcbik/77adac8990317f04651682107287f0d3/execroot/google3/blaze-out/k8-fastbuild/bin/third_party/llvm/llvm-project/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_index_dense.mlir.test.runfiles/google3/third_party/llvm/llvm-project/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_index_dense.mlir --sparse-compiler=enable-runtime-library=false | mlir-cpu-runner -e entry -entry-point-result=void -shared-libs=%mlir_c_runner_utils | FileCheck /usr/local/google/_blaze_ajcbik/77adac8990317f04651682107287f0d3/execroot/google3/blaze-out/k8-fastbuild/bin/third_party/llvm/llvm-project/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_index_dense.mlir.test.runfiles/google3/third_party/llvm/llvm-project/mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_index_dense.mlir

The only change that it ought to require is for Bazel to also substitute `@SHLIBDIR@` within `lit.site.cfg.py.in` correctly. It should expand to the directory where the runtime libraries are contained in. In the cmake build that'd be the `LLVM_SHLIB_OUTPUT_INTDIR` variable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143925/new/

https://reviews.llvm.org/D143925



More information about the llvm-commits mailing list