[PATCH] D144083: [JITLink] Initial 32-bit ARM backend

[Lang Hames via Phabricator via llvm-commits]

lhames added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/arm.h:33
+  /// Plain 32-bit pointer relocation; optional addend is stored in-place
+  Arm_Delta32 = FirstArmRelocation,
+
----------------
peter.smith wrote:
> Strictly speaking that would be a Data relocation (https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst#5613static-data-relocations) rather than an Arm state relocation.
> 
> Not sure if you are planning Arm state instruction support, may be worth making the distinction if you are.
Are you suggesting a different prefix for the name?

Other architectures have all stuck to `Delta<bitwidth>`, so unless there's some reason to distinguish this as "arm" I think it would make sense to rename to `Delta32`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144083/new/

https://reviews.llvm.org/D144083