[PATCH] D135462: [SelectionDAG] Do not second-guess alignment for alloca

Wed Feb 15 10:41:48 PST 2023

alexfh added a comment.

In D135462#4125826 <https://reviews.llvm.org/D135462#4125826>, @alexfh wrote:

> In D135462#4125805 <https://reviews.llvm.org/D135462#4125805>, @alexfh wrote:
>
>> In D135462#4115559 <https://reviews.llvm.org/D135462#4115559>, @asavonic wrote:
>>
>>> The patch is merged (again). Please let me know if it causes any regressions for in-tree targets or tests.
>>
>> An early heads up: we started seeing some test failures after this commit, but I can't yet tell whether the commit or the code is at fault.
>
> The only data point so far is that failures are happening on AArch64, which is alignment-sensitive.

False alarm. All the problems we've seen so far are due to UB in the code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135462/new/

https://reviews.llvm.org/D135462