[PATCH] D144066: [Pseudo probe] Duplicate probes in vectorized loop body.

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1287
   /// Returns true if \p I is known to be uniform after vectorization.
   bool isUniformAfterVectorization(Instruction *I, ElementCount VF) const {
+    // Pseudo probe needs to be run for each lane.
----------------
hoy wrote:
> wenlei wrote:
> > Will a non-uniform instruction in loop hinder vectorization? 
> It doesn't. When it gets here, pseudo probes already passed legality checks. In the regression test, the loop can be vectorized with probes duplicated.
How does this affect cost-benefit analysis? I saw it's used in `LoopVectorizationCostModel::getInstructionCost`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144066/new/

https://reviews.llvm.org/D144066