[PATCH] D144108: [mlir][LinAlg][Transform] Add a transform op for conv2d to im2col

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added a comment.
This revision is now accepted and ready to land.

LGTM for the TD part.

As a followup, we should build a utility that is able to take 2 AffineDimExpr such that we have an indexing of the form:

  LHS(..., a * d0 + b * d1, ...), RHS(..., d1, ...), RES(..., d0, ...)

and data-unroll/replicate the LHS along d1.

This should be a small 1-D utility based on a simple inference that resembles what has been introduced in https://reviews.llvm.org/D142661 https://reviews.llvm.org/D143584.
Then we can reuse the utility to work on any LinalgOp and avoid special casing 1-off C++ patterns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144108/new/

https://reviews.llvm.org/D144108