[PATCH] D117118: [NVPTX] Fix shr/and pair replace with bfe

Wed Feb 15 05:56:29 PST 2023

gmirazchiyski added a comment.

In D117118#4116094 <https://reviews.llvm.org/D117118#4116094>, @tra wrote:

> Does your patch make any difference for the first test case? AFACIT, it currently does not produce `bfe`: https://godbolt.org/z/94qG3E4xM

It does not affect the first case indeed. This can be either updated to use signed Int64 to cause the overflow and properly test this change, or removed leaving only the second test case which is the relevant one to testing this change.

@tra I think removing the current `bfe3` test and leaving `bfe4` as the only test, as well as adding more context to the diff should be sufficient completion of this patch. What do you think?

Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117118/new/

https://reviews.llvm.org/D117118