[PATCH] D143925: [mlir] Make the vast majority of integration and runner tests work on Windows

Wed Feb 15 05:47:29 PST 2023

awarzynski added inline comments.

================
Comment at: mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sampled_matmul.mlir:27
 // REDEFINE:   %VLA_ARCH_ATTR_OPTIONS \
 // REDEFINE:   --dlopen=%mlir_native_utils_lib_dir/libmlir_c_runner_utils%shlibext | \
 // REDEFINE: FileCheck %s
----------------
zero9178 wrote:
> awarzynski wrote:
> > Could you update this (and other similar `REDEFINE`s in mlir/test/Integration/Dialect/SparseTensor/CPU/) as well? Thanks!
> These paths use `%mlir_native_utils_lib_dir` which is not always substituted to the same as `%mlir_lib_dir` is. In particular, these may be set differently when using enumlators to execute the code. Since I'd certainly break such setups and I am unable to test these I left these as is and have disabled the SparseTensor tests on Windows
Ack, thanks for the explanation!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143925/new/

https://reviews.llvm.org/D143925