[PATCH] D143248: Emit CFI directives in epilogue and enable CFIFixup pass for RISC-V.

Wed Feb 15 05:43:02 PST 2023

jrtc27 added a comment.

In D143248#4128698 <https://reviews.llvm.org/D143248#4128698>, @varunkumare99 wrote:

> In D143248#4122933 <https://reviews.llvm.org/D143248#4122933>, @asb wrote:
>
>> Hi Varun - thanks for filing bug #60698 <https://github.com/llvm/llvm-project/issues/60698> to help track this issue, and for noticing that there should now be some upstream support for cfi_remember_state and cfi_restore_state.
>>
>> The first question that comes to my mind is what degree of testing you've done with this?
>
> Hi Alex,
> the patch updates over 500 testcases for RISCV(as it adds cfi info the epilogue), which results in a patch of over 30M. Due to which I'm not able to upload.

If that's the case it sounds like we have a lot of test cases that are emitting CFI directives that really should have nounwind.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143248/new/

https://reviews.llvm.org/D143248