[PATCH] D143980: [NFC][SeparateConstOffsetFromGEP] Added flag `lower-gep`

Liren.Peng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 03:36:22 PST 2023


Peakulorain added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp:1386
+    OS << "lower-gep";
+  OS << ">";
+}
----------------
arsenm wrote:
> arsenm wrote:
> > Single quotes
> > 
> They should all use single quotes, these use different overloads of <<
Sorry, I thought it was enough to keep the same usage as everyone else, then I will submit another patch and change all double quotes to single quotes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143980/new/

https://reviews.llvm.org/D143980



More information about the llvm-commits mailing list