[PATCH] D143941: AMDGPU: Teach getNegatedExpression about rcp

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 03:29:36 PST 2023


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/fneg-combines.new.ll:2033
 ; GCN-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
-; GCN-NEXT:    v_fma_f32 v0, -v0, v1, -2.0
+; GCN-NEXT:    v_fma_f32 v0, v0, v1, 2.0
 ; GCN-NEXT:    v_rcp_f32_e32 v0, v0
----------------
foad wrote:
> This codegen isn't actually any better, is it?
No, this particular test is just cosmetic. I'm mostly trying to avoid regressions from turning 0 into -0 in a future patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143941/new/

https://reviews.llvm.org/D143941



More information about the llvm-commits mailing list