[PATCH] D144079: [AArch64InstPrinter][llvm-objdump] Print ADR PC-relative label as a target address hexadecimal form
Simon Tatham via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 15 01:42:43 PST 2023
simon_tatham accepted this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.
A much needed improvement – thanks!
================
Comment at: llvm/test/tools/llvm-objdump/ELF/AArch64/pcrel-address.yaml:6
+# CHECK-NEXT: adr x0, 0x220000
+# CHECK-NEXT: adr x0, 0x201004 <_start+0xf04>
# CHECK-NEXT: adrp x2, 0x220000
----------------
Not that it matters for testing purposes, but did you mean to point that at 0x201000? Your other new adr matches the adrp that was there already.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144079/new/
https://reviews.llvm.org/D144079
More information about the llvm-commits
mailing list