[PATCH] D143175: [SimpleLoopUnswitch] Canonicalize conditions for injection of invariant condition

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

The patch itself seems straightforward. LGTM.



================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/inject-invariant-conditions.ll:193
 ; CHECK-NEXT:    [[LEN:%.*]] = load i32, ptr [[LEN_P:%.*]], align 4, !noundef !0
-; CHECK-NEXT:    br label [[LOOP:%.*]]
+; CHECK-NEXT:    [[INJECTED_COND:%.*]] = icmp ule i32 -2147483648, [[LEN]]
+; CHECK-NEXT:    br i1 [[INJECTED_COND]], label [[LOOP_US:%.*]], label [[LOOP:%.*]]
----------------
This seems unlikely profitable... Why not max from -2147483648 and [[LEN]]?

Or do I miss anything?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143175/new/

https://reviews.llvm.org/D143175