[PATCH] D139097: [ARM] Add option --print-raw-value to llvm-nm to dump raw symbol values in case of ARM
Subham Kedia via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 15 00:03:44 PST 2023
quic-subhkedi added inline comments.
================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:616
+ if (!SymOrErr)
+ // TODO: Test this error.
+ return SymOrErr.takeError();
----------------
jhenderson wrote:
> As above: the new code path should be tested.
this function is only used via the llvm-nm.cpp and is unreachable from there, so is it ok if we remove this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139097/new/
https://reviews.llvm.org/D139097
More information about the llvm-commits
mailing list