[PATCH] D144050: [SCEV] Strengthen nowrap flags via ranges for ARs on construction.

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

Wow. How do we live without that? :)

I remember that in the past attempts of lower inference of some flags led to some cyclic dependencies and infinite loops, so I don't know if it can be the case here. But hopefully testing will reveal that.



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:5739
+                   (SCEV::NoWrapFlags)(AR->getNoWrapFlags() |
+                                       proveNoWrapViaConstantRanges(AR)));
+  }
----------------
Should we update `Flags` here to have more optimistic flags for `BEInst`?


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:5870
+                         (SCEV::NoWrapFlags)(AR->getNoWrapFlags() |
+                                             proveNoWrapViaConstantRanges(AR)));
+        }
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144050/new/

https://reviews.llvm.org/D144050