[PATCH] D140806: Change getProcessTriple to return different archs in universal binary

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 21:57:06 PST 2023


jpienaar added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:1936
+#elif defined(__x86_64__) || defined(_M_X64)
+  if (PT.getArch() != llvm::Triple::x86_64)
+    PT.setArch(llvm::Triple::x86_64);
----------------
mehdi_amini wrote:
> Is the test useful here?
I think so, my rationale was if there were subtarget set then I'd not be clobbering it here to just set same target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140806/new/

https://reviews.llvm.org/D140806



More information about the llvm-commits mailing list