[PATCH] D143976: [ADT] Add lookupOrTrap method to DenseMap and StringMap

Xiangxi Guo (Ryan) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 21:50:48 PST 2023


StrongerXi added a comment.

In D143976#4127948 <https://reviews.llvm.org/D143976#4127948>, @lattner wrote:

> We generally don't worry to much about compatibility issues.  It is good to deprecate the old name for a few weeks before removing it, but we don't do long cycles here.
>
> I also don't like the 'at' name particularly, but it is highly precedented by the STL.  I think any alternate name would have to be really good to overcome that.

Sounds good; renaming to `at`:).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143976/new/

https://reviews.llvm.org/D143976



More information about the llvm-commits mailing list