[PATCH] D143535: github: Add manual workflow to build and upload release binaries

[Tom Stellard via Phabricator via llvm-commits]

tstellar marked 2 inline comments as done.
tstellar added inline comments.


================
Comment at: .github/workflows/release-binaries.yml:34-43
+        test "${{ github.actor }}" = "tstellar" || test "${{ github.actor }}" = "tru"
+        echo "${{ github.ref_name }}" | grep -e '^llvmorg-[0-9]\+\.[0-9]\+\.[0-9]\+\(-rc[0-9]\+\)\?$'
+        release_version=`echo "${{ github.ref_name }}" | sed 's/llvmorg-//g'`
+        release=`echo "$release_version" | sed 's/-.*//g'`
+        build_dir=`echo "$release_version" | sed 's,^[^-]\+,final,' | sed 's,[^-]\+-rc\(.\+\),rc\1,'`
+        rc_flags=`echo "$release_version" | sed 's,^[^-]\+,-final,' | sed 's,[^-]\+-rc\(.\+\),-rc \1 -test-asserts,' | sed 's,--,-,'`
+        echo "release-version=$release_version" >> $GITHUB_OUTPUT
----------------
thieta wrote:
> This block is very messy. I would l prefer if this ended up in a script or something instead. Going to be complicated to troubleshoot this logic when it lives in the action definition.
OK, I will move this to a script.


================
Comment at: .github/workflows/release-binaries.yml:53
+        target:
+          - triple: x86_64-linux-gnu-ubuntu-22.04
+            runs-on: ubuntu-22.04-8x32
----------------
thieta wrote:
> Is this the correct triple? I would have expected `x86_64-unknown-linux-gnu` or something similar instead. At least since we pass this directly as LLVM_DEFAULT_TARGET I think we need to be careful to get this right.
> 
> Probably better to have a `buildname` and `triple` separated.
The triple is only used for naming the tarball, not for anything else.


================
Comment at: .github/workflows/release-binaries.yml:87
+        -no-checkout
+        -no-test-suite || true
+
----------------
thieta wrote:
> if we pipe this to true won't we miss errors that happens here then?
Since this is being run after the tag has been created, I think it's OK to ignore failures because it's too late to make changes at this point.  Also if we fail here, then the binaries won't be uploaded.

The alternative would be to drop the || true and change the 'Upload binaries' step to always run.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143535/new/

https://reviews.llvm.org/D143535